GH-3320: Refine lifecycle control in StdIntFlow #3322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3320 Turns out that lifecycle control for the whole bunch of components in one `IntegrationFlow` is useful in fields. * Change the logic in the `StandardIntegrationFlow` to let to call `start()` and `stop()` independently how the flow was registered in the application context. This way it can be autowired as a `Lifecycle` to let end-user to avoid the search for proper component in the flow to stop or start manually - all the components registered with the flow are going to be stopped or started respectively
garyrussell
approved these changes
Jul 2, 2020
| if (this.lifecycles.size() > 0) { | ||
| AggregatingCallback aggregatingCallback = new AggregatingCallback(this.lifecycles.size(), callback); | ||
| ListIterator<SmartLifecycle> iterator = this.lifecycles.listIterator(this.lifecycles.size()); | ||
| while (iterator.hasPrevious()) { |
There was a problem hiding this comment.
I didn't notice this, but stopping right to left was wrong; corrected in the new code.
There was a problem hiding this comment.
No, Gary, it was right. Because we started before from right to left and filled out the local lifecycles property.
Then we used this lifecycles in the stop() and therefore the first one in the flow was in the end of that list, so we again should iterate it backwards to stop in proper order.
Right now indeed we don't have an intermediate list therefore the logic is changed around a normal integrationComponents state.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3320
Turns out that lifecycle control for the whole bunch of components
in one
IntegrationFlowis useful in fields.StandardIntegrationFlowto let to callstart()andstop()independently how the flow was registered inthe application context.
This way it can be autowired as a
Lifecycleto let end-user toavoid the search for proper component in the flow to stop or start
manually - all the components registered with the flow are going
to be stopped or started respectively