Add gauges for queue channel size #3349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `QueueChannel` provides a current size and remaining capacity metrics * Add Micrometer gauges into `QueueChannel` to expose the current values of the size and remaining capacity **Cherry-pick to 5.3.x, 5.2.x & 5.1.x**
* Document new gauges for queue channel
|
LGTM; but NPEs in travis tests. |
micheljung
reviewed
Jul 28, 2020
spring-integration-core/src/main/java/org/springframework/integration/channel/QueueChannel.java
Outdated
Show resolved
Hide resolved
artembilan
commented
Jul 28, 2020
spring-integration-core/src/main/java/org/springframework/integration/channel/QueueChannel.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Michel Jung <michel.jung89@gmail.com>
garyrussell
pushed a commit
that referenced
this pull request
Jul 28, 2020
* Add gauges for queue channel size
The `QueueChannel` provides a current size and remaining capacity metrics
* Add Micrometer gauges into `QueueChannel` to expose the current values
of the size and remaining capacity
**Cherry-pick to 5.3.x, 5.2.x & 5.1.x**
* * Revert `@SuppressWarnings("unchecked")` for test
* Document new gauges for queue channel
* * Fix IntegrationManagementConfigurer for NPE on `metricsCaptor`
* Fix wording in meter descriptions
Co-authored-by: Michel Jung <michel.jung89@gmail.com>
Co-authored-by: Michel Jung <michel.jung89@gmail.com>
garyrussell
pushed a commit
that referenced
this pull request
Jul 28, 2020
* Add gauges for queue channel size
The `QueueChannel` provides a current size and remaining capacity metrics
* Add Micrometer gauges into `QueueChannel` to expose the current values
of the size and remaining capacity
**Cherry-pick to 5.3.x, 5.2.x & 5.1.x**
* * Revert `@SuppressWarnings("unchecked")` for test
* Document new gauges for queue channel
* * Fix IntegrationManagementConfigurer for NPE on `metricsCaptor`
* Fix wording in meter descriptions
Co-authored-by: Michel Jung <michel.jung89@gmail.com>
Co-authored-by: Michel Jung <michel.jung89@gmail.com>
garyrussell
pushed a commit
that referenced
this pull request
Jul 28, 2020
* Add gauges for queue channel size
The `QueueChannel` provides a current size and remaining capacity metrics
* Add Micrometer gauges into `QueueChannel` to expose the current values
of the size and remaining capacity
**Cherry-pick to 5.3.x, 5.2.x & 5.1.x**
* * Revert `@SuppressWarnings("unchecked")` for test
* Document new gauges for queue channel
* * Fix IntegrationManagementConfigurer for NPE on `metricsCaptor`
* Fix wording in meter descriptions
Co-authored-by: Michel Jung <michel.jung89@gmail.com>
Co-authored-by: Michel Jung <michel.jung89@gmail.com>
micheljung
reviewed
Jul 29, 2020
| The https://github.com/spring-projects/spring-integration/blob/master/spring-integration-core/src/test/java/org/springframework/integration/support/management/micrometer/MicrometerCustomMetricsTests.java[MicrometerCustomMetricsTests] test case shows a simple example of how to do that. | ||
| You can also further customize the meters by overloading the `build()` methods on builder subclasses. | ||
|
|
||
| Starting with version 5.1.13, the `QueueChannel` exposes Micrometer gauges for queue size and remaining capacity: |
There was a problem hiding this comment.
@artembilan
Isn't this misleading? In the 5.1.x branch this might be true but 5.2.8.RELEASE and 5.3.2.RELEASE don't have this feature.
There was a problem hiding this comment.
Well, it even misleads you when you try to upgrade from 5.1.13 to those 5.2.8 or 5.3.2, because there is no that fix yet.
So, it was always about upgrading to the latest minor version of the particular point generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
QueueChannelprovides a current size and remaining capacity metricsQueueChannelto expose the current valuesof the size and remaining capacity
Cherry-pick to 5.3.x, 5.2.x & 5.1.x