Subscribe to Publisher in the NullChannel #3448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a Gitter discussion on the matter: https://gitter.im/spring-projects/spring-integration?at=5fdb3542d75db604c1959651 |
If a payload of the message in the flow is a `org.reactivestreams.Publisher`, it must be subscribed somewhere downstream to initiate reactive processing. The `NullChannel` just ignores the message altogether and therefore `Publisher` is lost * Check the payload of the message in the `NullChannel` for `Publisher` type and subscribe to it * Verify in the test and mention this logic in the docs **Cherry-pick to 5.4.x**
artembilan
force-pushed
the
NullChannel_&_Publisher
branch
from
cc92412 to
e051f0d
Compare
garyrussell
suggested changes
Dec 22, 2020
spring-integration-core/src/main/java/org/springframework/integration/channel/NullChannel.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Gary Russell <grussell@vmware.com>
garyrussell
added a commit
that referenced
this pull request
Dec 22, 2020
* Subscribe to Publisher in the NullChannel If a payload of the message in the flow is a `org.reactivestreams.Publisher`, it must be subscribed somewhere downstream to initiate reactive processing. The `NullChannel` just ignores the message altogether and therefore `Publisher` is lost * Check the payload of the message in the `NullChannel` for `Publisher` type and subscribe to it * Verify in the test and mention this logic in the docs **Cherry-pick to 5.4.x** * Apply suggestions from code review Co-authored-by: Gary Russell <grussell@vmware.com> Co-authored-by: Gary Russell <grussell@vmware.com>
|
Cherry-picked as 5ed8c11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a payload of the message in the flow is a
org.reactivestreams.Publisher,it must be subscribed somewhere downstream to initiate reactive processing.
The
NullChanneljust ignores the message altogether and thereforePublisheris lost
NullChannelforPublishertypeand subscribe to it
Cherry-pick to 5.4.x