Fix Websocket dynamic registration mapping order #3580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to https://stackoverflow.com/questions/67923303/dynamic-registration-of-websocket-output-adapter-is-not-working By default the `AbstractHandlerMapping` comes with the `order = Ordered.LOWEST_PRECEDENCE` which sorts added mappings to the end of chain. At the same time Spring Boot registers a `SimpleUrlHandlerMapping` as a fallback for all not handled requests leaving our own mapping behind consideration * Add `order = 0` to the `IntegrationDynamicWebSocketHandlerMapping` bean registration to let it to be consulted before `SimpleUrlHandlerMapping` * Add a note into `web-sockets.adoc` that `@EnableWebsocket` would disable Spring Integration dynamic WebSocket endpoints
garyrussell
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://stackoverflow.com/questions/67923303/dynamic-registration-of-websocket-output-adapter-is-not-working
By default the
AbstractHandlerMappingcomes with theorder = Ordered.LOWEST_PRECEDENCEwhich sortsadded mappings to the end of chain.
At the same time Spring Boot registers a
SimpleUrlHandlerMappingas a fallback for all not handled requestsleaving our own mapping behind consideration
order = 0to theIntegrationDynamicWebSocketHandlerMappingbean registration to let it to beconsulted before
SimpleUrlHandlerMappingweb-sockets.adocthat@EnableWebsocketwould disable Spring Integration dynamic WebSocketendpoints