GH-3643: Defer MeterRegistry bean dependency #3645
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3643
The
ImportBeanDefinitionRegistrar
register its bean definition in the early phase.It causes a problem with Spring Boot when an explicit
@EnableIntegrationManagement
is declared: the
MeterRegistry
is provided later on via auto-configurationand
MicrometerMetricsCaptor
has no knowledge aboutMeterRegistry
at theImportBeanDefinitionRegistrar
phase.MicrometerMetricsCaptorRegistrar
to theMicrometerMetricsCaptorConfiguration
and use special conditional
MicrometerMetricsCaptorImportSelector
for that@EnableIntegrationManagement
.This way a
MicrometerMetricsCaptor
@Bean
consultsObjectProvider<MeterRegistry>
on its creating time and returns
null
if noMeterRegistry
beans at all.