GH-3734: Support MessageHistory on Kafka deser #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3734 The `MessageHistory` is not in the trusted packages of the `DefaultKafkaHeaderMapper` therefore it fails when `MessageHistory.read()` is performed. * Configure default `DefaultKafkaHeaderMapper` in the `SubscribableKafkaChannel`, `KafkaInboundGateway`, `KafkaMessageDrivenChannelAdapter` and `KafkaMessageSource` to also trust packages exposed via `JacksonJsonUtils.DEFAULT_TRUSTED_PACKAGES` which include a `MessageHistory`, too. * Verify in some integration Kafka tests to be sure that `MessageHistory` is deserialized properly in the transferred headers * Rework some tests to use `@EmbeddedKafka` instead of `@BeforeAll/@AfterAll` **Cherry-pick to `5.5.x`**
garyrussell
reviewed
Mar 22, 2022
...n-kafka/src/main/java/org/springframework/integration/kafka/inbound/KafkaInboundGateway.java
Show resolved
Hide resolved
|
...cherry-picked as eec3e95 after resolving conflicts. |
|
Changing |
|
It has been fixed in the #3761. Will be released in a couple weeks - April 19th. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3734
The
MessageHistoryis not in the trusted packages of theDefaultKafkaHeaderMappertherefore it fails when
MessageHistory.read()is performed.Configure default
DefaultKafkaHeaderMapperin theSubscribableKafkaChannel,KafkaInboundGateway,KafkaMessageDrivenChannelAdapterandKafkaMessageSourceto also trust packages exposed via
JacksonJsonUtils.DEFAULT_TRUSTED_PACKAGESwhich include a
MessageHistory, too.Verify in some integration Kafka tests to be sure that
MessageHistoryisdeserialized properly in the transferred headers
Rework some tests to use
@EmbeddedKafkainstead of@BeforeAll/@AfterAllCherry-pick to
5.5.x