Add JDBC Spring Boot sample #454
Conversation
| @Configuration | ||
| public class H2Initializer { | ||
|
|
||
| @Bean |
There was a problem hiding this comment.
Is this necessary with newer versions of Boot? I thought this was automatically setup to /h2-console via H2ConsoleAutoConfiguration?
There was a problem hiding this comment.
You're absolutely correct. To make my oversight more comical I've just used Boot's H2 console auto-configuration in one of my projects a few days ago :)
There was a problem hiding this comment.
On a sidenote - websocket sample could also be changed to use auto-configuration for H2 console.
There was a problem hiding this comment.
Happens to me sometimes too. It just shows you are a long time Boot user :)
There was a problem hiding this comment.
On a sidenote - websocket sample could also be changed to use auto-configuration for H2 console.
Good point! I created #457
rwinch
added
the
status: waiting-for-feedback
|
Thanks for the PR @vpavic! You are really rocking Spring Session as of late :) I provided a few comments inline. |
|
Thank you @rwinch :) |
vpavic
force-pushed
the
jdbc-boot-sample
branch
from
c99e4b7 to
8238e91
Compare
|
@rwinch I've updated the PR. |
rwinch
removed
the
status: waiting-for-feedback
vpavic
force-pushed
the
jdbc-boot-sample
branch
from
8238e91 to
85e1b8d
Compare
|
@rwinch I've updated the PR... again :) |
|
Nice work! Thanks for the PR..This is now merged into master |
I've signed the CLA.