Expose attributes in MongoHttpSessionConfiguration #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @since 1.2.0 | ||
| */ | ||
| @ContextConfiguration | ||
| public class MongoHttpSessionConfigurationITests extends AbstractMongoRepositoryITests { |
There was a problem hiding this comment.
This shouldn't be an integration test.
eddumelendez
force-pushed
the
gh-489
branch
3 times, most recently
from
fa517a9 to
7d39eb7
Compare
rwinch
added
the
status: waiting-for-feedback
|
LGTM |
| public class MongoHttpSessionConfigurationTest { | ||
|
|
||
| private AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext(); | ||
|
|
There was a problem hiding this comment.
Should have an @After that closes the context
Attributes collectionName and maxInactiveIntervalInSeconds can be set now. See spring-projectsgh-489
|
@rwinch fixed |
|
Thanks for the PR! This is merged via edbf8bf |
rwinch
added
status: duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes collectionName and maxInactiveIntervalInSeconds can be set
now.
See gh-489