-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring 5 support #1773
Comments
There definite is a plan to support it. It will however have to wait till Open API support is completed. |
Spring 5 was released. Do u have any progress? |
@oleg-savko Unfortunately now. Would love some help on this one. Anyone wanting to help with that. |
@dilipkrish - Would like to contribute to #1773,can you help me with getting started guide. |
@amitsaluja frankly I haven't tried it andI don't know what it will take. I suspect certain functionality is not working or is broken.
Thank you for wanting to help! |
Hi @dilipkrish |
Hi @dilipkrish, I think the WebFlux support will be a very important milestone for springfox.
For (1), currently, RequestHandler depends on class NameValueExpression, PatternsRequestCondition and RequestMappingInfo is in webmvc package. They have the counter part in webflux "org.springframework.web.reactive" (see the link). Shall we consider.
|
@MinosPong thanks for your detailed analysis. I would agree with your findings. I really don't have the bandwidth to work on this right now and could use some help. |
swagger+netty server+webflux with kotlin is so cool. |
@JackFish baby steps :) |
Hello, I need this feature on my project.
Now, I will try to rewrite my code to work with springmvc and spring-webflux in parallel. My big issue is that springfox-core depend of spring-webmvc, I think broke this dependency can broke some dependent projects. Has someone already start a fork of springfox to work on that? |
I have a verry first working swagger lib on this fork : https://github.com/deblockt/springfox Is there anyone to work with me on this? |
Hi, I checked out your project and managed to adopt it in one of my projects, currently migrated to spring-boot-2.0.0.M7. Few things I noticed right away though,
|
@deblockt that is really cool!! Would love to help and answer any questions you might have. Let me know if you'd like access to this repo work on it. |
@deblockt nice work! |
@deblockt Would you like to send a PR to pull your changes in. |
@remesh22 te config works, but no maps the class Mono or Flux |
For those who need Spring Framework 5 + OpenAPI support, be aware there is now also a community driven support for OpenAPI built on top of Spring Rest docs, see https://github.com/ePages-de/restdocs-api-spec. At the same time, I hope SpringFox 3.0 with Spring Framework 5 support will be out soon. |
@mikezerosix: I am using spring boot 2 and springfox 3 snapshot Were you able to resolve this? Anyone else has solution for this? |
@j-ibarra same question with you now . have you already fixed it? |
Do you have an idea/plan when the 3.0.0 will be released on Maven Central? |
@bestshiyuhua, no! |
@j-ibarra @bestshiyuhua not sure if this is the same problem, but I have the content model now showing, not the Mono/Flux {} problem, by configuring genericModelSubstitutes, like so
Hoping this gets released officially soon |
@maccamlc awesome, thank very much, this works for me @bestshiyuhua |
Can you share your project? |
tried with 3.0.0-SNAPSHOT, got this when accessing
|
|
@Sam-Kruglov I recall that I just set the containerResponse to List and all works .... I discovered this, plus genericModelSubstitutes by inspecting the annotation options. I'm new to spring fox but seems all the building blocks exist |
Did you ever find a solution for this issue? |
|
The SpringFox 3 (Snapshot version) Swagger UI documentation is not generating properly the File Input Button for FilePart. But working fine in Spring Doc Swagger UI.
Any help is appreciated. |
@Sam-Kruglov Did you manage, to solve the issue with ServerHttpRequest. ? |
@matus-krska if I remember correctly I tried this approach but actually I am still using 2.7. |
Are there any updates? In our project we need the springfox integration for webflux, but the Snapshot is in development for over three year. Are there any plans on when this feature will be released? Or is there a good workarround for using the 2.9.2 release with webflux? |
@Numbernick we had an ugly so-so solution working for 3.0 SNAPSHOT, but one day 3.0-SNAPSHOT started to track a newer release of Spring which completely broken all our builds so we dropped the idea using spring-fox with WebFlux altogether (yes, it is a bad practice to follow SNAPSHOT builds in your production builds but there was no other choice at that time). |
@Numbernick, @kimec release of 3.0.0 is planned on this month. OAS 3.0 is almost ready. We are porting other features for a new api. |
@MaksimOrlov Thank you very much for this information. I am looking forward to it :) |
@codemasterbish A workarround to make uploads work in the Swagger-UI is to set the FilePart to a MultipartFile |
I'm trying to use Springfox3 (Snapshot version) for my SpringWebflux project, I have used @EnableSwagger2WebFlux, but it is not showing any operations. I'm using RouteFunction to define routes, sample class is given below (kotlin) @configuration
} And I added @ApiOperation in the EmployeeHandler class methods (handleGetEmployees & handleGetEmployeeById) Will Springfox3 ((Snapshot version) ) be able to identify the paths/operations if we define the Route functions as above and @ApiOperation in handler class? |
podrias nuevamente compartir tu proyecto ya se rompio el enlace |
Or are there plans to support it?
The text was updated successfully, but these errors were encountered: