-
-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added connection timeout. Fixes #7417 #7438
Conversation
Added splatting fof command for readability
@@ -367,7 +367,7 @@ function Invoke-DbaDbDataMasking { | |||
|
|||
$query = "CREATE NONCLUSTERED INDEX [$($maskingIndexName)] ON [$($dbTable.Schema)].[$($dbTable.Name)]([$($identityColumn)])" | |||
|
|||
Invoke-DbaQuery -SqlInstance $server -SqlCredential $SqlCredential -Database $db.Name -Query $query | |||
Invoke-DbaQuery -SqlInstance $server -SqlCredential $SqlCredential -Database $db.Name -Query $query -QueryTimeout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a $ConnectionTimeout
missing at the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or better $CommandTimeout
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably the reason the tests fail.
Why do you use |
Formatted list for better readability
Splatted command Replaced connection timeout with command timeout
@andreasjordan You are correct, there was an obsolete parameter. |
🙌🏼 awesome, thank you both! |
Added splatting fof command for readability
Type of Change
.\tests\manual.pester.ps1
)Purpose
The invoke command the connection timeout to make sure that commands would not execute for a long period of time
Approach
Added variable to several query commands
Commands to test
Invoke-DbaDbDataMasking