case insensitive autocomplete

[mglatz]

Details for the issue

I'd love to have autocomplete on table names case insenstive. as My tables usually begin with uppercase char, I'd like if they would come up in autocomplete even if I start writing their name with lowercase.

Useful extra information

I'm opening this issue because:

• DB4S is crashing
• DB4S has a bug
• [ x] DB4S needs a feature
• DB4S has another problem

I'm using DB4S on:

• [ x] Windows: ( version: ___ )
• Linux: ( distro: ___ )
• Mac OS: ( version: ___ )
• Other: ___

I'm using DB4S version:

• [x ] 3.9.1
• 3.9.0
• Other: ___

I have also:

• Tried out the latest nightly version: https://github.com/sqlitebrowser/sqlitebrowser#nightly-builds
• Searched for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20

[chrisjlocke]

Wow, never knew that before. Most of my tables are normally always lowercase, so haven't come across this before. Can undertand why that would be undesirable.

[justinclift]

@mglatz This sounds like a reasonable idea. Not sure how easy or difficult it would be to add, but it wouldn't surprise me if we just needed to enable some option when we initialise our QScintilla bits (which we use for this).

This sounds like it might be the right kind of thing:

• http://pyqt.sourceforge.net/Docs/QScintilla2/classQsciScintilla.html#a8348c07fe8cff0bf6141a94ca3014ed2

Hmmm, it seems like we already set that to false:

• sqlitebrowser/src/sqltextedit.cpp

  Line 107 in 6c9c56a

  setAutoCompletionCaseSensitivity(false);

So maybe that's not the option we need for this... 😉

Someone else will probably know more about this stuff. 😄

[chrisjlocke]

It does say though, "Note that setting a lexer may change the case sensitivity." which is then what happens in line 118.

sqlitebrowser/src/sqltextedit.cpp

Line 118 in 6c9c56a

sqlLexer->setColor(Qt::black, QsciLexerSQL::Default);

Maybe the setAutoCompletionCaseSensitivity(false); could be put after that line, or debug what the case sensitivity is, to see if its been changed.

[justinclift]

Ahhh. We could move the whole if {} clause to after line 129.

As in, I can do that right now in our master branch, if someone wants to check the nightly build tomorrow. (?) 😄

[justinclift]

... or I could just test it myself right away. Hmmm, gimme a few mins... 😄

[justinclift]

Nope, that didn't work. The autocomplete didn't notice tables starting with a capital letter, so it seems like this will need more careful attention to figure out. 😉

I'll leave it to someone else instead, as my focus is elsewhere for now.

[MKleusberg]

This should be fixed in the next nightly build. @mglatz Can you download and try the nightly build tomorrow or some later day to confirm it's working for you? There's currently a bug in our nightlies which causes them to crash more frequently though - we'll try to fix that as soon as possible, too 😉

[chrisjlocke]

I can confirm this now works.

Prodding @mglatz ... ;) 🎋

[mglatz]

wow thanks! :)

[chrisjlocke]

If you can confirm it works OK for you, @mglatz, I'll close this issue. 🍾