Plot column checkboxes become checked again on refresh

[orimay]

Details for the issue

If I check a plot column, it gets a color. If I uncheck it, and then refresh data for the plot, the mark gets checked back. This is very annoying - I am forced to uncheck all the checkboxes, I ever checked, every time I refresh the data. Please make it so checkboxes don't get checked back on refresh.

Useful extra information

Weekly build does even worse - after refresh columns disappear at all.

I'm opening this issue because:

• DB4S is crashing
• DB4S has a bug
• DB4S needs a feature
• DB4S has another problem

I'm using DB4S on:

• Windows: ( version: Windows Server 2012 R2 )
• Linux: ( distro: ___ )
• Mac OS: ( version: ___ )
• Other: ___

I'm using DB4S version:

• 3.10.1
• 3.10.0
• 3.9.1
• Other: ___

I have also:

• Tried out the latest nightly version: https://github.com/sqlitebrowser/sqlitebrowser#nightly-builds
• Searched for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20

[mgrojo]

What you see in the nightly is probably caused by the same inner problem as #1222. This is how I reproduce it:

1. Draw a plot
2. Filter by one of the columns
3. Press refresh
4. The plot may disappear. The probability seems to be inverse to the number of rows.

This seems a race condition in the data loading.

[MKleusberg]

@orimay Can you download tomorrow's nightly build and check if it's working as expected in there? I think I could fix this bug but you never know 😉

@mgrojo That sounds like a different issue to me. I'll have a look into that now 😄

[chrisjlocke]

If I refresh data while the plot is open, DB4S crumples on the floor in a heap, sobbing.

https://screencast-o-matic.com/watch/cblioX2Cw7

This was on the nightly from 7 Dec. The nightl;y from Nov 6 doesn't.
Whoever put the dates in the 'About' box - thank you! 😍

[MKleusberg]

Sorry for the delay, @orimay! But can you check out tomorrow's nightly build and see if it's working for you? 😄

@mgrojo I believe the problem you saw was caused by the old and buggy multithreading code we had. Ironically the new multithreading code had the same issue but in a more reliable manner 😉 Anyway, I believe it is finally fixed now. Can you double check? I'm not 100% about the fix so it's worth a try before closing this.

[mgrojo]

All the reported problems were solved, but we forgot to report back and close this issue. I'll close it now.