New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot column checkboxes become checked again on refresh #1245

Closed
Orimay opened this Issue Nov 30, 2017 · 5 comments

Comments

Projects
None yet
5 participants
@Orimay
Copy link

Orimay commented Nov 30, 2017

Details for the issue

If I check a plot column, it gets a color. If I uncheck it, and then refresh data for the plot, the mark gets checked back. This is very annoying - I am forced to uncheck all the checkboxes, I ever checked, every time I refresh the data. Please make it so checkboxes don't get checked back on refresh.

Useful extra information

Weekly build does even worse - after refresh columns disappear at all.

I'm opening this issue because:

  • DB4S is crashing
  • DB4S has a bug
  • DB4S needs a feature
  • DB4S has another problem

I'm using DB4S on:

  • Windows: ( version: Windows Server 2012 R2 )
  • Linux: ( distro: ___ )
  • Mac OS: ( version: ___ )
  • Other: ___

I'm using DB4S version:

  • 3.10.1
  • 3.10.0
  • 3.9.1
  • Other: ___

I have also:

@mgrojo

This comment has been minimized.

Copy link
Contributor

mgrojo commented Nov 30, 2017

What you see in the nightly is probably caused by the same inner problem as #1222. This is how I reproduce it:

  1. Draw a plot
  2. Filter by one of the columns
  3. Press refresh
  4. The plot may disappear. The probability seems to be inverse to the number of rows.

This seems a race condition in the data loading.

@mgrojo mgrojo added the bug label Nov 30, 2017

@justinclift justinclift changed the title Plot column ckeckboxed get rechecked on refresh Plot column checkboxes become checked again on refresh Dec 1, 2017

MKleusberg added a commit that referenced this issue Dec 1, 2017

plot: Correctly restore Y axis check states
When restoring the plot state we always checked set the use-on-y-axis
checkbox when a colour was defined for a field. This is correct most of
the times because a field doesn't have a colour as long as it's not used
in the plot. However, when you uncheck a field it keeps its colour which
starts causing issues as soon these settings are reloaded.

The solution is to not only store the colour but also the check state
independently. This changes the project files format though, so the code
needs to support loading old and new file formats.

See issue #1245.
@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Dec 1, 2017

@Orimay Can you download tomorrow's nightly build and check if it's working as expected in there? I think I could fix this bug but you never know 😉

@mgrojo That sounds like a different issue to me. I'll have a look into that now 😄

@chrisjlocke

This comment has been minimized.

Copy link
Contributor

chrisjlocke commented Dec 7, 2017

If I refresh data while the plot is open, DB4S crumples on the floor in a heap, sobbing.

https://screencast-o-matic.com/watch/cblioX2Cw7

This was on the nightly from 7 Dec. The nightl;y from Nov 6 doesn't.
Whoever put the dates in the 'About' box - thank you! 😍

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Aug 16, 2018

Sorry for the delay, @Orimay! But can you check out tomorrow's nightly build and see if it's working for you? 😄

@mgrojo I believe the problem you saw was caused by the old and buggy multithreading code we had. Ironically the new multithreading code had the same issue but in a more reliable manner 😉 Anyway, I believe it is finally fixed now. Can you double check? I'm not 100% about the fix so it's worth a try before closing this.

@mgrojo

This comment has been minimized.

Copy link
Contributor

mgrojo commented Sep 8, 2018

All the reported problems were solved, but we forgot to report back and close this issue. I'll close it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment