New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to set the BLOB text. Preview for the displayed colors and text in Preferences. #1263

Closed
mgrojo opened this Issue Dec 10, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@mgrojo
Copy link
Contributor

mgrojo commented Dec 10, 2017

Details for the issue

Other browsers for SQLite allow configuring the text to be displayed in BLOB fields. This would the same we do for NULL fields, but applied now to BLOB fields.

Useful extra information

If we want this feature, I've thought in performing this improvement in the Data Browser tab in Preferences dialog, so we get a nice preview of the colors in the fields used for setting the NULL and BLOB texts (text field for Regular would function only as a preview, of course).

imagen

If this is welcome, I can contribute the implementation.

I'm opening this issue because:

  • DB4S is crashing
  • DB4S has a bug
  • DB4S needs a feature
  • DB4S has another problem

@mgrojo mgrojo added the enhancement label Dec 10, 2017

@mgrojo mgrojo self-assigned this Dec 10, 2017

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Dec 10, 2017

For anyone looking over this and wondering what the change is, this is a screenshot of the current tab layout:

preferences-before

@mgrojo's concept is to add an additional column to the "Field colors" section (and call it "Field display" instead), showing what the rendered text would look like if applied, and allowing for the user to choose the displayed text for BLOBs.

Personally, I reckon it's a good idea. That should make selecting a new text font and colour faster & easier for people before committing to it. 😄

mgrojo added a commit that referenced this issue Dec 11, 2017

Allow user to set the BLOB text. Preview for field display in Prefere…
…nces

A new setting allows the user to set the text for BLOB data in the cell.

The existing line-edit for setting the NULL text and the new one for BLOB
are updated with the cell background and foreground colors, providing a
preview of the desired changes. An additional preview-only box is added for
the regular fields.

See issue #1263

Settings in Database tab are left-aligned for consistency to other tabs.
See comment in #1173.

mgrojo added a commit that referenced this issue Dec 11, 2017

Preview for the Data Browser font in Preferences
The 'Displayed text' boxes preview now the Data Browser font that the user
sets in the corresponding widgets.

See issue #1263

mgrojo added a commit that referenced this issue Dec 11, 2017

Avoid warning in setPointSize when Preferences are opened
The warning was introduced in 387449b
because the initial value in the UI is 0.

See issue #1263.
@mgrojo

This comment has been minimized.

Copy link
Contributor Author

mgrojo commented Dec 19, 2017

This is already implemented. We can close it now, but anyone is still free to add any comments or feedback.

@mgrojo mgrojo closed this Dec 19, 2017

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Dec 20, 2017

Cool. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment