Mac version references incorrect shortcut

[ThinkDigitalSoftware]

Details for the issue

In Mac, it's Command + shift + click

What did you expect to see?

Command + shift + click

What did you see instead?

Ctrl + shift + click

Useful extra information

The info below often helps, please fill it out if you're able to. :)

What operating system are you using?

• Windows: ( version: ___ )
• Linux: ( distro: ___ )
• Mac OS: ( _version: 12.0 )
• Other: ___

What is your DB4S version?

• 3.10.1
• 3.10.0
• 3.9.1
• Other: ___

Did you also

• Try out the latest nightly version: https://github.com/sqlitebrowser/sqlitebrowser#nightly-builds
• Search for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20

[justinclift]

Ahhh. I know we've made some changes to the displayed shortcuts since the last release (3.10.1), but I'm not sure if they're for OSX or not.

Ironically... I don't have handy access to an OSX box atm, so can't really test the nightly build myself either. Um... if you do have a few minutes to check after all, it would be useful. 😇

[ThinkDigitalSoftware]

OK, just for you 😄

[ThinkDigitalSoftware]

Yes, it still shows the same incorrect shortcut in v3.10.99

[justinclift]

Thanks @ThinkDigitalRepair, we'll need to get that fixed then. 😄

[mgrojo]

I cannot test it under Mac, but according to Qt documentation, this particular case should be fixed now.

But there are other cases of key sequences referenced in tooltips or What's This info that cannot be fixed so easily. They are in *.ui files. If somebody knows have to fix these, please share here the tip:

EditDialog.ui:289:        <string>Apply data to cell [Ctrl+Return]</string>
MainWindow.ui:138:             <string>Refresh the data in the selected table [F5, Ctrl+R]</string>
MainWindow.ui:237: - Ctrl+&quot; for duplicating the current record.
MainWindow.ui:238: - Ctrl+' for copying the value from the cell above.
MainWindow.ui:1681:    <string>Execute all/selected SQL [F5, Ctrl+Return, Ctrl+R]</string>
MainWindow.ui:2063:    <string>Find text in SQL editor [Ctrl+F]</string>
MainWindow.ui:2084:    <string>Find or replace text in SQL editor [Ctrl+H]</string>
MainWindow.ui:2306:    <string>Print text from current SQL editor tab [Ctrl+P]</string>
PlotDock.ui:75:Click on points to select them in the plot and in the table. Ctrl+Click for selecting a range of points.

[ThinkDigitalSoftware]

According to this page .ui files are just plain text xml files

[justinclift]

Yeah, they are. Not sure how to add conditional compilation to those though, unlike with the .h/.cpp files where we do that fairly often.

eg (picking a random example here):

sqlitebrowser/src/Application.cpp

Lines 66 to 68 in 87310a6

	#ifdef Q_WS_WIN
	QApplication::addLibraryPath(QApplication::applicationDirPath() + "/plugins");
	#endif

With conditional compilation we can say effectively "If this is being compiled on OSX, use XYZ bit of code. If instead it's Windows, use ABC". That'd work for displaying different shortcuts for different platforms.

Even without conditional compilation, if the tool tip was created at run time we could do the same thing. With the string embedded directly like that though... not sure.

Maybe we could add some kind of runtime/startup code that - for OSX only - overwrites those tooltip strings in the created app?

[mgrojo]

@ThinkDigitalRepair The case that you reported should be fixed in a nightly build. Could you confirm that the change done in source actually converts the key name to what a Mac user expects?

The cases of tooltip defined in the ui files are pending until we get a good idea on how to translate the key names to a native name.

[ThinkDigitalSoftware]

@mgrojo, after checking, it has been fixed in the latest nightly. Thank you .