New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split "Execute SQL" tab vertically in query & result/feedback #380

Closed
pamtbaau opened this Issue Jul 8, 2015 · 27 comments

Comments

Projects
None yet
4 participants
@pamtbaau
Copy link

pamtbaau commented Jul 8, 2015

Since most screens are more wide then high and query texts rarely occupy the screen's entire width, the space in the "Execute SQL" tab could be used more efficiently if the query field could take up the entire left part of screen and the result/feedback fields were stacked on the right side.

Of course, the possibility to resize the left/right panes would be a bonus.

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jul 8, 2015

Seems like an interesting idea. I'm not sure how feasible it is though... one of the others - who knows Qt - will have to chime in. 😄

MKleusberg added a commit that referenced this issue Jul 8, 2015

Fix splitter between code editor and result view in Execute SQL tab
There was a supposed to be a splitter between the SQL code editor widget
and the result table view widget in the SQL execution areas in the
Execute SQL tab. A splitter like this allows resizing the widgets around
it. Apparently this was broken some time ago (probably by me) and is
fixed by this commit.

See #380 which is partially fixed by this.

MKleusberg added a commit that referenced this issue Jul 8, 2015

Add option for horizontal tiling between code editor and result view
Add a new option to the Preferences Dialog which activates horizontal
tiling between the SQL code editor and the result view in the Execute
SQL tab, i.e. the two widgets are shown side by side instead of one over
the other.

See issue #380.
@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Jul 8, 2015

I've added a new option to the Preferences dialog which, when activated, puts the result table view to the right side of the code editor. The success/error messages are still shown at the bottom, though, which looks a bit more aesthetic in my point of view. I've also (re-)introduced the possibility to resize the two panes.

If you want to check out the new feature, you'll have to wait for tomorrow's nightly build, download & install it and then click View -> Preferences, select the "SQL" tab and check the "Horizontal tiling" option at the bottom. Hope this helps 😄

@MKleusberg MKleusberg added this to the 3.8.0 - Awesome Sauce! milestone Jul 8, 2015

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Jul 8, 2015

Wow, this is truly swift!

I'll have a look tomorrow...

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jul 8, 2015

@MKleusberg You're a legend dude. 😁

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Jul 9, 2015

The views are not expanding vertically...

Having considered the aesthetics, I still prefer the success/error pane to be stacked underneath the results pane. The editing of the query is the main task in this window hence its view should be most comfortable/efficient.

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jul 9, 2015

@pamtbaau Are you ok to try the nightly build (tomorrow), to see if the latest commits from @MKleusberg makes it better?

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Jul 9, 2015

@justinclift Sure I will with this amount of speed and effort put in by MKleusberg... :-)

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Jul 10, 2015

@MKleusberg @justinclift Just tested the nightly build of July 10th. It works like a charm!

  • I've got a 50% increase in vertical space, which gives me much more oversight when editing and testing my queries.
  • I also like I don't need to scroll down the entire success/error pane any more to see the performance figure of the query.

Thank you! I compliment you on your responsiveness....

Just out of curiosity, why is the query repeated in the success/error pane? I don't see an added value over the same text in the query pane. Wouldn't messages like "no such column: l.locationId" or "5 rows returned in 52ms" be enough on their own?

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Jul 13, 2015

Cool! I'm glad I could help 😃 And thanks a lot for the feedback!

The query gets repeated since the first version I've ever used, long before I've started helping out in development. So to be honest I've no idea why it was added to the message string. However, with the more recent version (3.0+) it kind of makes sense to repeat it because these versions allow you to execute multiple queries at once. Now, assuming you get an error or some query results, it might be unclear from which query they originate. This is at least why I think it serves some purpose to have them in there.

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jul 13, 2015

Hmmm, this issue seems like it's fully done now. Are we ok to close it from your point of view @pamtbaau? 😄

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Jul 13, 2015

@justinclift Yes from my point of view this issue can be closed. Thanks for your support.

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Oct 9, 2017

After upgrading to 3.10.1 it seems the 'Execute SQL' windows has been redesigned. I would very much like the changes to be reversed. Most important parts are query panel and result panel. The query feedback panel is least interesting and should not occupy 1/3 of the screen width.

It would suggest the following (as it was before):
Left side: 1/2 of screen for query panel
Right side: vertically stacked query result panel and query feedback panel

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Oct 9, 2017

@pamtbaau We moved the "Export to CSV" button on the right side of the bottom most pane to the top panel, after a report by a new user that it was confusing as-it-was (#1122). Is that what you're meaning? 😄

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Oct 9, 2017

I mean the layout as in this screenshot below. This is how it was in 3.9.0

screenshot

Moving the 'save as' button from the lower right corner into the buttonbar (#1122) is a good suggestion by the way.

MKleusberg added a commit that referenced this issue Oct 11, 2017

Improve splitter in Execute SQL tab
Set a maximum height for the error area in the Execute SQL tab. This way
it doesn't occupy as much space by default.

Use two separate splitters instead of just one. This fixes the
horizontal tiling option.

See issue #380.
@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Oct 12, 2017

@pamtbaau Ahhh. You're probably wanting the "Horizontal tiling" option under Preferences -> SQL:

preferences-horizontal_tiling_option

With it disabled:

execute_sql-horizontal_tiling_disabled

With it enabled:

execute_sql-horizontal_tiling_enabled

Does that help? 😄

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Oct 12, 2017

I do have "horizontal tiling" enabled but don't get your layout. On my Windows 10, I get three vertical columns + the 'save as' button on the side.
Db Browser version: 3.10.1

sqlbrowser

@chrisjlocke

This comment has been minimized.

Copy link
Contributor

chrisjlocke commented Oct 12, 2017

Was just going to post the same ... on my DB4S, the SQL Log isn't along the bottom.

image

(Using nightly from 6 Oct)

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Oct 12, 2017

Ahhh. That's probably what the commit last night did then: ce18198

I'd just updated and rebuilt from our latest source before taking that screenshot, without knowing that's what it did. Sorry.

On a related note, it seems like our Windows nightly builds are broken at the moment due to a different recent code change (#1169). It might take a few days for us to get this new windows breakage fixed though. 😦

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Oct 12, 2017

Yep, I've fixed this issue yesterday but then got distracted for some reason and didn't update this issue 😄

@pamtbaau We'll let you know as soon as our nightlies our running again, so you can update without problems 😉

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Oct 12, 2017

@pamtbaau The Windows nightly builds are running again now, so (in theory) any nightly build from tomorrow onwards will have the fixed layout bits in it. 😄

    https://nightlies.sqlitebrowser.org/latest/

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Oct 13, 2017

Thanks @justinclift.
The nightly does indeed have the new layout... Much better!

(I still slightly prefer the 3.9 layout in which the error feedback panel is stacked vertically underneath the sql result panel and consumes half its current space...)

MKleusberg added a commit that referenced this issue Oct 13, 2017

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Oct 13, 2017

Thanks for the feedback, @pamtbaau. You're right, it makes more sense the way it was in 3.9. So I've just fixed it to more resemble the 'old' layout. Can you check again using tomorrow's nightly build and see if that's good for you? 😄

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Oct 14, 2017

@MKleusberg Yes, the layout is almost back as it was in version 3.9 :-)
Except.... that the columns are squeezed into the width of the column names.

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Oct 15, 2017

Ah, that's a side-effect of the multi-threading thing I've been trying to implement over the last couple of days. Thanks for pointing this out! I'll try to fix it soon-ish 😄

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Oct 15, 2017

Ok, sooner than expected 😉 I've just prepared a fix for that, too. You can check again using tomorrow's nightly build. If you notice any further oddities in the nightly build, feel free to report them. I'm currently making some larger changes and it's good to know when things break 😄

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Oct 16, 2017

@MKleusberg Width of columns in query results are fine now.

Ok, if you really want me to, I will keep nagging if things break... :-)

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Oct 16, 2017

Yes, please do! 😄 With all the different options and features in DB4S now, it's gotten to the point where I can't really test a change in all scenarios anymore. So if you use horizontal tiling or pay attention to the default column widths, that's awesome and definitely helps a lot 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment