Add keyboard shortcuts modal help #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosms
requested review from
smacker,
ricardobaeta,
dpordomingo and
se7entyse7en
smacker
approved these changes
Dec 21, 2018
|
Already talked with @carlosms about this on slack and "only the help button, and then inside the modal, the link to the reference and the keyboard shortcut list" seems like an elegant solution to this UI. Sorry for missing this notification. |
dpordomingo
approved these changes
Jan 11, 2019
frontend/src/components/HelpModal.js
Outdated
| <Modal show={showModal} onHide={onHide} bsSize="medium"> | ||
| <Modal.Header> | ||
| <Modal.Title> | ||
| KEYBOARD SHORTCUTS |
There was a problem hiding this comment.
I'd prefer un text-transform with CSS
frontend/src/components/HelpModal.js
Outdated
| <tbody> | ||
| <tr> | ||
| <td className="keys"> | ||
| <div className="key">Ctrl</div> +{' '} |
There was a problem hiding this comment.
mmmm... is the {' '} any kind of sorcery to add space between + and Enter?
If so, why not using a left padding/margin, or a cleaner ?
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
carlosms
force-pushed
the
keyboard-help
branch
from
a916237 to
6054671
Compare
|
Redone as one modal including the gitbase docs link and the shortcuts table, including the suggestions made by @dpordomingo
|
se7entyse7en
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #293.
@ricardobaeta please comment on icon placement. Also, it would be good if you could provide it as
svginstead ofpng, like the rest of the icons.Although it feels to me it is not too subtle for a help icon... One thing we could change: remove this keyboard icon, and have the top-right 'Help' button we already have open a modal with the text: