Skip to content

Conversation

erizocosmico
Copy link
Contributor

Depends on #214 and #216, just review last commit

Another dramatic cut in memory usage. This one's even higher:

BenchmarkKallaxUpdateWithRelationships-4   	     200	   6084449 ns/op	   25921 B/op	     570 allocs/op
BenchmarkKallaxUpdate-4                    	     300	   4169555 ns/op	    4201 B/op	     102 allocs/op
BenchmarkKallaxUpdateWithRelationships-4   	     200	   5436011 ns/op	    6643 B/op	     175 allocs/op
BenchmarkKallaxUpdate-4                    	     300	   4010681 ns/op	     656 B/op	      25 allocs/op

@codecov
Copy link

codecov bot commented Aug 2, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@90dca92). Click here to learn what that means.
The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #217   +/-   ##
=========================================
  Coverage          ?   79.17%           
=========================================
  Files             ?       19           
  Lines             ?     3650           
  Branches          ?        0           
=========================================
  Hits              ?     2890           
  Misses            ?      549           
  Partials          ?      211
Impacted Files Coverage Δ
store.go 88.1% <97.05%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90dca92...47fd3a5. Read the comment docs.

Copy link

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico erizocosmico merged commit 5543a44 into src-d:master Aug 3, 2017
@erizocosmico erizocosmico deleted the perf/update branch August 3, 2017 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants