improve memory footprint and performance of deletes #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
=========================================
Coverage ? 79.18%
=========================================
Files ? 19
Lines ? 3651
Branches ? 0
=========================================
Hits ? 2891
Misses ? 549
Partials ? 211
Continue to review full report at Codecov.
|
Serabe
approved these changes
Aug 2, 2017
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
perf/delete
branch
from
a875285 to
c3baf72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #214, #216 and #217, just review last commit.
Didn't even bother to add the benchmarks for this. After seeing the results of the previous PRs there's some gain for sure.