This repository was archived by the owner on Jan 28, 2021. It is now read-only.
sql/analyzer: replace column indexes with GetFields in SortFields #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes src-d#144 Even if literals were being parsed correctly as the Column in the SortFields, we were not acting accordingly on the Sort node, because it acted as a literal and not a GetField expression. This commit adds a rule to replace the Literal expression inside the SortField Column field into an UnresolvedColumn that will get resolved as any other column in the tree. By doing this with a rule, we avoid handling this special case inside the Sort node. Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
mcarmonaa
approved these changes
Apr 3, 2018
jfontan
approved these changes
Apr 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144
Even if literals were being parsed correctly as the Column in the SortFields, we were not acting accordingly on the Sort node, because it acted as a literal and not a GetField expression.
This commit adds a rule to replace the Literal expression inside the SortField Column field into an UnresolvedColumn that will get resolved as any other column in the tree. By doing this with a rule, we avoid handling this special case inside the Sort node.