This repository was archived by the owner on Jan 28, 2021. It is now read-only.
*: add comments to all exported members #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erizocosmico
force-pushed
the
comment-docs
branch
2 times, most recently
from
b29110c to
a935e69
Compare
|
Done, can be reviewed now |
mcarmonaa
suggested changes
Feb 16, 2018
sql/expression/aggregation.go
Outdated
| @@ -34,15 +40,18 @@ func (c *Count) Resolved() bool { | |||
| return c.Child.Resolved() | |||
| } | |||
|
|
|||
| // Name returns the of the node. | |||
There was a problem hiding this comment.
s/returns the of/returns the name of
|
Depends on #19 so tests pass |
erizocosmico
force-pushed
the
comment-docs
branch
from
a935e69 to
6e50839
Compare
|
Fixed @mcarmonaa |
mcarmonaa
approved these changes
Feb 16, 2018
erizocosmico
force-pushed
the
comment-docs
branch
from
6e50839 to
7a9ce15
Compare
ajnavarro
approved these changes
Feb 16, 2018
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
comment-docs
branch
from
7a9ce15 to
9bae74d
Compare
erizocosmico
pushed a commit
that referenced
this pull request
Oct 22, 2019
Fixed test error caused by deleting Alterable interface.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also made
golint,go vetandgofmt -shappy and simplified some code.