This repository was archived by the owner on Jan 28, 2021. It is now read-only.
sql/(parse,plan): implement describe queries #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
reviewed
Jun 14, 2018
engine_test.go
Outdated
| @@ -491,6 +503,8 @@ func testQuery(t *testing.T, e *sqle.Engine, q string, r []sql.Row) { | |||
| rs = append(rs, row) | |||
| } | |||
|
|
|||
| spew.Dump(rs) | |||
|
Yep. Agh, every single time.
On Thu, 14 Jun 2018 at 17:43, Antonio Navarro Perez <notifications@github.com<mailto:notifications@github.com>> wrote:
@ajnavarro commented on this pull request.
________________________________
In engine_test.go<#222 (comment)>:
@@ -491,6 +503,8 @@ func testQuery(t *testing.T, e *sqle.Engine, q string, r []sql.Row) {
rs = append(rs, row)
}
+ spew.Dump(rs)
leftover?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#222 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABQFF8lJDBWVq735QvnBXkrkXQktcFjjks5t8oSXgaJpZM4UoG29>.
|
erizocosmico
force-pushed
the
feature/explain
branch
from
bbdfab8 to
9a968b6
Compare
|
Fixed @ajnavarro |
|
@erizocosmico I think you need to rebase. |
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
feature/explain
branch
from
9a968b6 to
d60eeb7
Compare
|
Done |
ajnavarro
reviewed
Jun 15, 2018
| err *errors.Kind | ||
| }{ | ||
| { | ||
| "DESCRIBE TABLE foo", |
There was a problem hiding this comment.
Describe table should work too. Is it still being parsed somewhere?
There was a problem hiding this comment.
Yep, just not here
ajnavarro
approved these changes
Jun 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #216