This repository was archived by the owner on Jan 28, 2021. It is now read-only.
sql/plan: more efficient implementation of GroupBy #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #331
Before:
Now:
Aggregations without a grouping clause are now more than 2x faster, 25-30% faster with grouping. Memory usage is an order of magnitude lower than before.
Even if having the code branching into grouping/no grouping and end up with some repeated code, I preferred that path because, as the benchmarks say, it's way faster and it's a pretty common use case to aggregate without grouping.