Skip to content

Conversation

MattShirley
Copy link
Collaborator

Adds a parameter to the deliver function that prints styled text via the rich lib. This is currently enabled by default for both direct Python code and the CLI (my decision, this PR can be adjusted to change that if needed).

To disable on Python:

deliver(spec, display_results=False)

To disable with CLI:

servicex deliver examples/config_FuncADL_Uproot.yaml --hide-results

Example output:

% hatch run servicex deliver examples/config_FuncADL_Uproot.yaml
Delivering examples/config_FuncADL_Uproot.yaml to ServiceX cache
Uproot_FuncADL_YAML: Transform ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3/3 00:35
                      Download ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3/3 00:40

✓ ServiceX Delivery Complete!

                                                               Delivered Files
┏━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Sample              ┃ File Count ┃ Files                                                                                                  ┃
┡━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ Uproot_FuncADL_YAML │          3 │ /private/var/folders/h6/k0_2vvjd3rz1tw9d0xw9t9sc0000gn/T/ServiceX_Client/cache-dir/679ef47c-2755-48f0… │
│                     │            │ /private/var/folders/h6/k0_2vvjd3rz1tw9d0xw9t9sc0000gn/T/ServiceX_Client/cache-dir/679ef47c-2755-48f0… │
│                     │            │ /private/var/folders/h6/k0_2vvjd3rz1tw9d0xw9t9sc0000gn/T/ServiceX_Client/cache-dir/679ef47c-2755-48f0… │
└─────────────────────┴────────────┴────────────────────────────────────────────────────────────────────────────────────────────────────────┘

Total files delivered: 3
Screenshot 2025-09-08 at 5 05 47 PM

@MattShirley MattShirley linked an issue Sep 8, 2025 that may be closed by this pull request
@MattShirley MattShirley requested review from ponyisi and BenGalewsky and removed request for ponyisi and BenGalewsky September 8, 2025 22:06
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.28%. Comparing base (1413cd7) to head (550cb80).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
+ Coverage   97.19%   97.28%   +0.08%     
==========================================
  Files          29       29              
  Lines        1959     1987      +28     
==========================================
+ Hits         1904     1933      +29     
+ Misses         55       54       -1     
Flag Coverage Δ
unittests 97.28% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@BenGalewsky BenGalewsky merged commit 86ad240 into master Sep 30, 2025
53 checks passed
@BenGalewsky BenGalewsky deleted the 648-clean-up-the-file-list-when-returned-by-client branch September 30, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up the file list when returned by client
2 participants