Ci dynamic matrix and rename #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angerman
force-pushed
the
ci-dynamic-matrix-and-rename
branch
from
4de99d0 to
23dd6fa
Compare
|
Interestingly, this now seems to fail due to the missing rts sublib issues. That are fixed in #44. Specifically this: |
angerman
force-pushed
the
ci-dynamic-matrix-and-rename
branch
3 times, most recently
from
dabc558 to
bbb815a
Compare
angerman
force-pushed
the
stable-ghc-9.14
branch
from
a10be51 to
d3180ae
Compare
angerman
force-pushed
the
stable-ghc-9.14
branch
4 times, most recently
from
d9f06c2 to
a1edbb5
Compare
angerman
force-pushed
the
ci-dynamic-matrix-and-rename
branch
2 times, most recently
from
7c8212f to
e74ec54
Compare
…gger to stable-ghc-9.14
This reverts commit d821074.
This is kidna stupid. Julian hit something similar with the THREADED one :-/
Ideally, ghc should just be able to produce this data outright, without having to resort to a separate tool. This seems highly questionable. It would be much better if ghc should emitted this information in a structured way.
This seems conceptually wrong. I don't fully understand why we need this?
angerman
force-pushed
the
ci-dynamic-matrix-and-rename
branch
from
b78b210 to
1967f08
Compare
this is stupid, but it will have to do for now for dyanmic.
angerman
changed the base branch from
stable-ghc-9.14
to
stable-ghc-9.14-rebased
angerman
commented
Sep 17, 2025
Comment on lines
+263
to
+274
| sanitized_hc := $(subst $(space),_,$(subst :,_,$(subst /,_,$(subst \,_,$(TEST_HC))))) | ||
| test_hc_hash := $(shell \ | ||
| if command -v openssl >/dev/null 2>&1; then \ | ||
| openssl dgst -sha256 $(TEST_HC) | awk '{print substr($$2, 1, 8)}'; \ | ||
| elif command -v sha256sum >/dev/null 2>&1; then \ | ||
| sha256sum $(TEST_HC) | awk '{print substr($$1, 1, 8)}'; \ | ||
| elif command -v shasum >/dev/null 2>&1; then \ | ||
| shasum -a 256 $(TEST_HC) | awk '{print substr($$1, 1, 8)}'; \ | ||
| else \ | ||
| echo "no_hash"; \ | ||
| fi) | ||
| ghc_config_mk = $(TOP)/mk/$(test_hc_hash)_ghcconfig$(sanitized_hc).mk |
There was a problem hiding this comment.
I should add a comment here why we do this. It adds a has to the ghc config file. This ensure we always read the correct ghcconfig, if the ghc changed, the hash changed, and we recompute.
angerman
commented
Sep 17, 2025
angerman
commented
Sep 17, 2025
|
|
||
| visibility: public | ||
|
|
||
| ghc-options: -optc-DRtsWay="v" |
There was a problem hiding this comment.
Julian has "rts_v" and others in #75 for this.
hsyl20
reviewed
Sep 17, 2025
| (NoArg (setGeneralFlag Opt_NoHsMain)) | ||
| , make_ord_flag defGhcFlag "no-rts" | ||
| (NoArg (setGeneralFlag Opt_NoRts)) | ||
| , make_ord_flag defGhcFlag "no-ghc-internal" |
There was a problem hiding this comment.
We have the following dependeny as visible to cabal:
ghc-internal
+ rts
however, ghc will try to insert:
ghc-internal
+ rts-sublib (based on the -threaded / -debug flag)
+ rts
If we try to build the rts-sublib with ghc, we can end up trying to load ghc-internal, due to auto-injection of libraries.
Maybe a better solution is to add a flag to outright disable ghc's auto population of libs, instead of having separate ones for each lib 😅
This is needed until haskell/cabal#11221 is properly addressed to ensure that a linked dynamic binary will have the appropriate path for the rts (sublib).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.