Repository navigation
Replies: 2 comments
|
Since the changes have been merged, I'll close this discussion. |
0 replies
|
@akiya3 thanks for the super clear writeups 🙏 |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
I would like the maintainers to establish a clear product decision on which workspace should be deleted when using keyboard shortcuts or mouse actions.
The related fix PRs propose different deletion targets for the same shortcut. Since individual PRs do not provide a clear picture of the intended behavior going forward, I have brought together the history and current proposals in this Discussion. I would appreciate an explicit decision from the maintainers on the intended behavior and how the existing PRs should proceed.
Previous behavior
Reviewing the history shows that the current hover requirement was introduced by changing an existing command that deleted the active workspace.
The August PR explicitly states that the intent was to avoid having to switch focus or open the context menu before deleting a workspace.
The diff replaces the existing logic for deleting the active workspace with logic for deleting the hovered workspace. The tests added at the time also explicitly require the command to do nothing when no workspace is hovered.
This change removed the behavior introduced in May, where an assigned shortcut could delete the active workspace independently of mouse position, and replaced it with behavior that requires hovering.
Current behavior and proposed fixes
The deletion shortcut currently targets the hovered workspace, while the Cmd+J deletion action still targets the active workspace.
There are currently two open PRs addressing #17815, which reports that the shortcut does nothing unless a workspace is hovered.
If the pointer is resting on a workspace other than the active one, these proposals delete different workspaces. They cannot both be adopted as written as the behavior of the same command.
#19277 also proposed targeting the active workspace, but it was closed without being merged.
Separately, #38724, which fixed shortcut handling while typing in chat, has been merged, and its originating issue, #38501, is closed. #26882 reports that neither the default nor a reassigned shortcut works, but whether it has the same root cause remains unconfirmed.
My view: delete the workspace selected through keyboard interaction
I believe the deletion shortcut should target the workspace selected through keyboard interaction, without consulting mouse position.
When focus is in a terminal or chat, pressing Cmd+Shift+Delete should delete the active workspace. When focus is in the workspace list, it should delete the workspace selected with the Up and Down arrow keys. The selection made through keyboard interaction should directly determine the deletion target.
This means that after pressing Cmd+Shift+0 to move to the list and selecting a workspace with the arrow keys, users should not need to move focus back to the central terminal or chat. They should be able to keep focus in the list and press the deletion shortcut to proceed with deleting the selected workspace.
Hover-first targeting prevents this workflow from working reliably. Even after selecting a different workspace in the list, a pointer left over another workspace takes precedence. A hover check cannot distinguish between a pointer that happens to remain somewhere after browser use or switching applications and a pointer deliberately placed over the workspace the user wants to delete. The problem is that even after selecting a workspace with the keyboard, users still have to check or move the mouse before deleting it.
In a comment describing the same list-based workflow, @joerhew also reports that selecting a workspace with the keyboard and pressing the deletion shortcut produces no response, forcing them to return to the mouse.
Hover-based targeting does have an advantage: it allows users to quickly delete another workspace without switching away from their current workspace. However, deleting a workspace without opening it remains available through that row’s context menu.
Weighing that convenience against consistent keyboard behavior, I believe the deletion shortcut should follow the selection made through keyboard interaction. Whether the target is the active workspace or the workspace selected in the list, mouse position should not change which workspace is deleted.
That is my view. I am sharing this with @AmethystLiang @MTGVim @eranartzi @AntonioKL @lucacri @shjeong92 @brennanb2025 @joerhew so that the related reports and proposals can be considered together in one place.
I have taken care to review the code and past issues and PRs, but I apologize if I have missed anything.
All reactions