Skip to content

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Sep 17, 2025

Description

Follow up to #1064, which introduced uppercase characters in domain names. The updated format was used for domain names as well as container names in Kubernetes for example. But, actually, the Kubernetes RFC 1123 specification is slightly different, only allowing lowercase characters, see https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-label-names. This PR adjusts the separation of usage between the two.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@xeniape xeniape self-assigned this Sep 17, 2025
@xeniape xeniape changed the title fix: separate between official and kubernetes-native RFC 1123 definition fix: Don't allow uppercase characters in Kubernetes object names Sep 17, 2025
@xeniape xeniape marked this pull request as ready for review September 17, 2025 08:03
xeniape and others added 2 commits September 20, 2025 11:03
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xeniape xeniape added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit 1c05735 Sep 22, 2025
8 checks passed
@xeniape xeniape deleted the fix/no-uppercase-in-kubernetes-resource-names branch September 22, 2025 07:20
@xeniape xeniape moved this from Development: In Review to Development: Done in Stackable Engineering Sep 22, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants