chore(operator/eos): Adjust the warning message #1103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techassi
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
lfrancke
requested changes
Oct 2, 2025
| "the operator reached end-of-support" | ||
| eos.built.datetime = built_datetime, | ||
| eos.build.age = build_age, | ||
| "This operator version was built on {built_datetime} ({build_age} days ago) and may has reached end-of-support. \ |
There was a problem hiding this comment.
Suggested change
| "This operator version was built on {built_datetime} ({build_age} days ago) and may has reached end-of-support. \ | |
| "This operator version was built on {built_datetime} ({build_age} days ago) and may have reached end-of-support. \ |
|
One typo. I can't really comment on the Rust changes :( Thank you! |
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
sbernauer
reviewed
Oct 2, 2025
|
|
||
| ### Changed | ||
|
|
||
| - Update the end-of-support warning message ([#1103]) |
There was a problem hiding this comment.
I personally wouldn't add a new changelog entry, but just add this PR number to Add end-of-support checker.
EOS was never released, this change might confuse users, as they will not see the change.
Not blocking this PR though
Comment on lines
+156
to
+157
| eos.built.datetime = built_datetime, | ||
| eos.build.age = build_age, |
There was a problem hiding this comment.
Is built vs build intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the end-of-support warning message as discussed in today's meeting.