-
-
Notifications
You must be signed in to change notification settings - Fork 16
feat!: Add new ListenerClass.stickyNodePorts
field
#1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
What (k8s resources changes) does it result in? Some changes to generated Services or just the generated Listener? |
Actually the |
Please vote on this comment |
/// However, this only works on setups with long-living nodes. If your nodes are rotated on | ||
/// a regular basis, the Pods previously running on a removed node will be stuck in Pending | ||
/// until you delete the PVC with the stickiness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Could we somehow detect this and automatically remove the stickiness? Or is that something we don't want?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we have auto-detection in listener-op, which detects what ListenerClasses it should create, based on detecting GKE/AKS/IONOS etc. You might recall this from the CRD maintainer discussions.
But that's a follow-up
Co-authored-by: Techassi <git@techassi.dev>
Description
Part of stackabletech/issues#770
Implementation is in stackabletech/listener-operator#340
Definition of Done Checklist
Author
Reviewer
Acceptance