Skip to content

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 7, 2025

Description

Part of stackabletech/issues#770
Implementation is in stackabletech/listener-operator#340

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@NickLarsenNZ
Copy link
Member

NickLarsenNZ commented Oct 8, 2025

What (k8s resources changes) does it result in? Some changes to generated Services or just the generated Listener?

@sbernauer
Copy link
Member Author

What (k8s resources changes) does it result in?

Actually the csi::v1::Volume, which in turn influences the created PVC (I guess). Feel free to have a look at rust/operator-binary/src/csi_server/controller.rs in stackabletech/listener-operator#340

@sbernauer
Copy link
Member Author

Please vote on this comment

Comment on lines +76 to +78
/// However, this only works on setups with long-living nodes. If your nodes are rotated on
/// a regular basis, the Pods previously running on a removed node will be stuck in Pending
/// until you delete the PVC with the stickiness.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Could we somehow detect this and automatically remove the stickiness? Or is that something we don't want?

Copy link
Member Author

@sbernauer sbernauer Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we have auto-detection in listener-op, which detects what ListenerClasses it should create, based on detecting GKE/AKS/IONOS etc. You might recall this from the CRD maintainer discussions.
But that's a follow-up

Co-authored-by: Techassi <git@techassi.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Waiting for Review
Development

Successfully merging this pull request may close these issues.

3 participants