Skip to content

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented May 7, 2024

Rustls now requires a global provider to be set, or explicitly passed in via the server/client config.

Normally this would be set by the application, and not in a library, however this library is to remove so much boiler plate from our applications.

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

…et, or explicity pass in via the server/client config.

Normally this would be set by the application, and not in a library, however this library is to remove so much boiler plate from our applications.
@NickLarsenNZ NickLarsenNZ requested a review from Techassi May 7, 2024 14:23
@NickLarsenNZ NickLarsenNZ self-assigned this May 7, 2024
@NickLarsenNZ NickLarsenNZ changed the title fix(stackable-webhook): pass a tls provider in the ServerConfig fix(stackable-webhook): Pass a tls provider in the ServerConfig May 7, 2024
@NickLarsenNZ NickLarsenNZ changed the title fix(stackable-webhook): Pass a tls provider in the ServerConfig fix(stackable-webhook): Explicitly set the TLS provider for the ServerConfig, and enable "safe" protocols May 7, 2024
Techassi
Techassi previously approved these changes May 15, 2024
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit f2f1b6b May 24, 2024
@NickLarsenNZ NickLarsenNZ deleted the fix/webhook-tls-provider branch May 24, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants