Skip to content

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Jun 4, 2024

Description

Part of stackabletech/issues#531

Now each tracing subscriber log level can be configured via the given environment variable.

let trace_guard = Tracing::builder()
    .service_name("hdfs_operator")
    .with_console_output("HDFS_OPERATOR_LOG", LevelFilter::INFO)
    .with_otlp_log_exporter("HDFS_OPERATOR_OTLP_LOG", LevelFilter::DEBUG)
    .with_otlp_trace_exporter("HDFS_OPERATOR_OTLP_TRACE", LevelFilter::TRACE)
    .build();

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@Techassi Techassi self-requested a review June 4, 2024 09:01
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor nit-picks.

@NickLarsenNZ NickLarsenNZ requested a review from Techassi June 4, 2024 13:13
@NickLarsenNZ NickLarsenNZ enabled auto-merge June 5, 2024 07:46
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit 84646f2 Jun 5, 2024
@NickLarsenNZ NickLarsenNZ deleted the feat/trace-filter-env-var branch June 5, 2024 10:31
NickLarsenNZ added a commit to Techassi/dummy-webhook that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants