Skip to content

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Jun 10, 2024

Description

Set strum::Display for LogLevel to uppercase and add warning.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@xeniape xeniape added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit 4b8cbc4 Jun 10, 2024
@xeniape xeniape deleted the derive-display-for-loglevel branch June 10, 2024 12:32
@nightkr
Copy link
Contributor

nightkr commented Jun 10, 2024

Where did this come up? Would it be more appropriate to not implement Display at all? I assume that the naming here was trying to align with something in the first place, are we drifting out of compat with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants