Skip to content

refactor(stackable-telemetry): Support Option<T> in subscriber methods #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 5, 2025
Merged

refactor(stackable-telemetry): Support Option<T> in subscriber methods #951

merged 15 commits into from
Mar 5, 2025

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Jan 28, 2025 •
edited by NickLarsenNZ
Loading

Part of stackabletech/issues#639

As requested in #901 (comment), this PR enables this:

.with_otlp_log_exporter(
  otlp_log_flag.then(|| Settings::builder()
    .with_environment_variable("ABC_OTLP_LOG")
    .with_default_level(LevelFilter::INFO)
    .build()
  )
)

Techassi
Techassi commented Jan 28, 2025
View reviewed changes
This was referenced Jan 28, 2025
Merged
Closed
@NickLarsenNZ @Techassi
Apply suggestions from code review
0087662 
Co-authored-by: Techassi <git@techassi.dev>
@Techassi Techassi changed the title refactor: Support Option<T> in subscriber methods refactor(stackable-telemetry): Support Option<T> in subscriber methods Jan 28, 2025
@Techassi Techassi marked this pull request as ready for review January 28, 2025 16:12
nightkr
nightkr reviewed Jan 29, 2025
View reviewed changes
github-actions[bot]
github-actions bot reviewed Jan 29, 2025
View reviewed changes
@NickLarsenNZ NickLarsenNZ requested review from nightkr and NickLarsenNZ and removed request for NickLarsenNZ February 24, 2025 10:27
maltesander
maltesander approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Decided to revisit the problems later.

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit 0d23102 Mar 5, 2025
10 checks passed
@NickLarsenNZ NickLarsenNZ deleted the feat/stackable-telemetry-options branch March 5, 2025 08:17
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Mar 7, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@maltesander maltesander maltesander approved these changes

@nightkr nightkr Awaiting requested review from nightkr

Assignees

@NickLarsenNZ NickLarsenNZ

@Techassi Techassi

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Techassi @nightkr @NickLarsenNZ @maltesander