Skip to content

chore: Bump Rust version and workflow actions #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 28, 2025
Merged

chore: Bump Rust version and workflow actions #973

merged 6 commits into from
Feb 28, 2025

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Feb 28, 2025 •
edited
Loading

Part of #970

This PR:

  • Bumps to Rust toolchain to 1.84.1
  • Bumps various actions used in workflows to their newest version
  • Hardens the workflows by applying suggestions from zizmor

@Techassi Techassi self-assigned this Feb 28, 2025
@Techassi Techassi mentioned this pull request Feb 28, 2025
Closed
@Techassi Techassi marked this pull request as ready for review February 28, 2025 14:47
@Techassi Techassi moved this to Development: Waiting for Review in Stackable Engineering Feb 28, 2025
NickLarsenNZ
NickLarsenNZ previously approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question about the Rust toolchain version.

@Techassi @NickLarsenNZ
chore: Apply suggestion
ab0a0ab 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Feb 28, 2025
NickLarsenNZ
NickLarsenNZ approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi enabled auto-merge February 28, 2025 15:14
@Techassi Techassi added this pull request to the merge queue Feb 28, 2025
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Feb 28, 2025
Merged via the queue into main with commit a79a3a1 Feb 28, 2025
10 checks passed
@Techassi Techassi deleted the chore/bump-rust-toolchain-1.84.1 branch February 28, 2025 15:25
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@Techassi Techassi

Labels
release/25.3.0
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Techassi @NickLarsenNZ