allow a litte more context for big comment trees

huumn · huumn · commit 6c6afefdb79c · 2025-11-12T19:11:16.000-06:00
diff --git a/lib/item.js b/lib/item.js
@@ -1,4 +1,4 @@
-import { COMMENT_DEPTH_LIMIT, FULL_COMMENTS_THRESHOLD, OLD_ITEM_DAYS } from './constants'
+import { COMMENT_DEPTH_LIMIT, COMMENTS_OF_COMMENT_LIMIT, FULL_COMMENTS_THRESHOLD, OLD_ITEM_DAYS } from './constants'
 import { datePivot } from './time'
 
 export const defaultCommentSort = (pinned, bio, createdAt) => {
@@ -106,10 +106,12 @@ export const deleteReminders = async ({ id, userId, models }) => {
 }
 
 export const commentSubTreeRootId = (item, root) => {
+  const path = item.path.split('.')
+
+  // if this is a limited comment tree, we can't be sure comments at our depth are visible
+  // beyond COMMENTS_OF_COMMENT_LIMIT, so COMMENTS_OF_COMMENT_LIMIT is the max depth we can navigate to
   if (item.root?.ncomments > FULL_COMMENTS_THRESHOLD || root?.ncomments > FULL_COMMENTS_THRESHOLD) {
-    return item.id
+    return path.slice(-COMMENTS_OF_COMMENT_LIMIT)[0]
   }
-
-  const path = item.path.split('.')
   return path.slice(-(COMMENT_DEPTH_LIMIT - 1))[0]
 }

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { COMMENT_DEPTH_LIMIT, FULL_COMMENTS_THRESHOLD, OLD_ITEM_DAYS } from './constants'`
	`1`	`+import { COMMENT_DEPTH_LIMIT, COMMENTS_OF_COMMENT_LIMIT, FULL_COMMENTS_THRESHOLD, OLD_ITEM_DAYS } from './constants'`
`2`	`2`	`import { datePivot } from './time'`
`3`	`3`
`4`	`4`	`export const defaultCommentSort = (pinned, bio, createdAt) => {`
`@@ -106,10 +106,12 @@ export const deleteReminders = async ({ id, userId, models }) => {`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`export const commentSubTreeRootId = (item, root) => {`
	`109`	`+ const path = item.path.split('.')`
	`110`	`+`
	`111`	`+ // if this is a limited comment tree, we can't be sure comments at our depth are visible`
	`112`	`+ // beyond COMMENTS_OF_COMMENT_LIMIT, so COMMENTS_OF_COMMENT_LIMIT is the max depth we can navigate to`
`109`	`113`	`if (item.root?.ncomments > FULL_COMMENTS_THRESHOLD \|\| root?.ncomments > FULL_COMMENTS_THRESHOLD) {`
`110`		`- return item.id`
	`114`	`+ return path.slice(-COMMENTS_OF_COMMENT_LIMIT)[0]`
`111`	`115`	`}`
`112`		`-`
`113`		`- const path = item.path.split('.')`
`114`	`116`	`return path.slice(-(COMMENT_DEPTH_LIMIT - 1))[0]`
`115`	`117`	`}`