Prevent infinite loop when catching errors. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an error is caught, the parser's while loop would continue to run without advancing, as the return value of `take` would always be true. By always returning false, parsing will stop when an error is raised, caught or otherwise.
|
Since you're not watching the repo, /cc @chrisdickinson :) |
|
Awesome, thanks for pinging me! |
chrisdickinson
added a commit
that referenced
this pull request
Apr 4, 2014
Prevent infinite loop when catching errors.
|
No worries, thanks for the speedy merge! |
|
published as 0.0.6. |
|
(and also thanks again!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an error is caught, the parser's while loop would continue to run without advancing, as the return value of
takewould always be true.By always returning false, parsing will stop when an error is raised, caught or otherwise.
Thanks! :)