Skip to content

vault_pki: Fix writing out cert if common name is empty #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2022
Merged

vault_pki: Fix writing out cert if common name is empty #32

merged 1 commit into from
Dec 2, 2022

Conversation

mnasiadka
Copy link
Member

No description provided.

@mnasiadka mnasiadka requested a review from a team as a code owner December 2, 2022 13:06
k-s-dean
k-s-dean approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@k-s-dean k-s-dean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if the common name is empty. Which generally it shouldn't be. The certificate will be written out as the IP address of the cert. This looks ok to me.

@mnasiadka mnasiadka merged commit 150a9d9 into master Dec 2, 2022
@mnasiadka mnasiadka deleted the vault_pki_write_cert branch December 2, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@k-s-dean k-s-dean k-s-dean approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnasiadka @k-s-dean