Skip to content

vault_pki: Fix writing out cert if common name is empty #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2022
Merged

vault_pki: Fix writing out cert if common name is empty #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion roles/vault_pki/tasks/create_cert.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,14 @@
register: certificate_data

- name: "Write out certificate pem_bundle"
vars:
cert_name: "{{ item.item.common_name if item.item.common_name | length > 0 else item.item.extra_params.ip_sans }}"
copy:
content: |
{{ item.data.certificate }}
{{ item.data.issuing_ca }}
{{ item.data.private_key }}
dest: "{{ vault_pki_certificates_directory }}/{{ item.item.common_name | replace(' ', '-') }}.pem"
dest: "{{ vault_pki_certificates_directory }}/{{ cert_name | replace(' ', '-') }}.pem"
mode: 0600
delegate_to: "{{ vault_pki_write_certificates_host }}"
loop: "{{ certificate_data.results }}"
Expand Down