Add support for configuring proxy settings #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priteau
requested changes
Jun 28, 2022
|
Nice to see CI catching issues! |
Change-Id: Ic5130a7512d4a26354bd292b0ab51ab4a9279f0a (cherry picked from commit e48960e)
jovial
force-pushed
the
feature/wallaby/proxy
branch
from
2e4b26d to
bc66f63
Compare
Change-Id: I6515d028914e8956eac23662c3714a908fda6ac4 (cherry picked from commit 5ede876)
The no_proxy list should only contain domains, hostnames, IP addresses and networks, but docker_registry is often in the form ip_address:port. Use urlsplit to extract the hostname from the docker_registry variable after prepending http:// to turn it into a valid URL. Also add missing infra-vms to hosts in proxy.yml. Change-Id: I6424fc405894514a63fb2b641637bbb9d5c070c0 (cherry picked from commit 71eb21a)
|
Done, thanks. |
priteau
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ic5130a7512d4a26354bd292b0ab51ab4a9279f0a
(cherry picked from commit e48960e)