-
Notifications
You must be signed in to change notification settings - Fork 23
Adds pulp_proxy_url #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulp requires you to the proxy for each remote.
This is untested when the pulp_proxy_url is unmodified, but I think you can use omit like this:
|
markgoddard
reviewed
Feb 4, 2022
I've cherry-picked the proxy support to wallaby here: stackhpc/kayobe#18 |
markgoddard
previously approved these changes
Jun 28, 2022
priteau
previously approved these changes
Jun 28, 2022
markgoddard
reviewed
Jul 19, 2022
markgoddard
reviewed
Aug 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the same for the Apt repos?
The default did not work well when using a proxy deployed on the seed. Leave it up the user to explictly enable.
Done |
markgoddard
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulp requires you to set the proxy for each remote.