Skip to content

Conversation

jovial
Copy link

@jovial jovial commented Jan 18, 2022

No description provided.

dougszumski and others added 4 commits January 4, 2022 14:58
This uses the binary release from GitHub.

Change-Id: Id7df96e7d5b646d4b42e06945bafdbce828b902b
Co-Authored-By: Pierre Riteau <pierre@stackhpc.com>
(cherry picked from commit 034419e)
This can be used to forward Prometheus Alertmanager notifications to
Microsoft Teams.

Change-Id: I57ebdf734c4bf38045ca8f837dc7066cdeb16131
(cherry picked from commit ae05a9d)
Change-Id: I2a28befb6c4e3baf30e9929ae7ea224945ec7210
(cherry picked from commit a13b42f)
@jovial jovial requested a review from markgoddard January 18, 2022 12:30
&& tar xvf /tmp/prometheus_openstack_exporter.tar.gz -C /opt/ \
&& rm -f /tmp/prometheus_openstack_exporter.tar.gz \
&& ln -s /opt/openstack-exporter* /opt/openstack-exporter
ARG prometheus_openstack_exporter_url=https://github.com/stackhpc/openstack-exporter/archive/refs/heads
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ARG prometheus_openstack_exporter_url=https://github.com/stackhpc/openstack-exporter/archive/refs/heads
ARG prometheus_openstack_exporter_url=https://github.com/openstack-exporter/openstack-exporter/archive/refs/heads

Maybe default to this instead?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably makes sense to do everything either in config or code. It might be possible to get all of these changes into a block override, but probably not worth it. i.e. stay with this approach until the patch is merged.

@jovial jovial merged commit eef4f39 into stackhpc/wallaby Jan 19, 2022
@jovial jovial deleted the wallaby-backports branch January 19, 2022 09:56
jovial added a commit to stackhpc/stackhpc-release-train that referenced this pull request Jan 19, 2022
jovial added a commit to stackhpc/stackhpc-kayobe-config that referenced this pull request Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants