Switch to downstream fork of cloudkitty #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings in a few additional features not in the regular wallaby release.
markgoddard
reviewed
Jan 18, 2022
etc/kayobe/kolla.yml
Outdated
| RUN pip install git+https://github.com/stackhpc/cloudkitty.git@stackhpc/wallaby | ||
| horizon_footer: | | ||
| # Fixes CloudKitty pricing panel: https://github.com/stackhpc/cloudkitty-dashboard/pull/1 | ||
| RUN pip install git+https://github.com/stackhpc/cloudkitty-dashboard.git@stackhpc/wallaby |
There was a problem hiding this comment.
Could you use the kolla_sources approach rather than footers?
There was a problem hiding this comment.
Oh yeah, missed that thanks.
jovial
commented
Jan 18, 2022
etc/kayobe/kolla.yml
Outdated
| location: "{{ kolla_bifrost_source_url }}" | ||
| reference: "{{ kolla_bifrost_source_version }}" | ||
| cloudkitty-base: | ||
| # Backport of NOTNUMBOOL: https://review.opendev.org/c/openstack/cloudkitty/+/774084 |
There was a problem hiding this comment.
Not sure if I should bother maintaining these comments here as they may get out of sync with the branch. Thoughts?
There was a problem hiding this comment.
They could go stale, maybe leave them out.
These could go stale. At the time of writing we are carrying the following patches: horizon-plugin-cloudkitty-dashboard: - Fixes CloudKitty pricing panel: stackhpc/cloudkitty-dashboard#1 cloudkitty-base: - Backport of NOTNUMBOOL: https://review.opendev.org/c/openstack/cloudkitty/+/774084 - Support customising Prometheus queries: https://review.opendev.org/c/openstack/cloudkitty/+/817275
The last commit removed more than just the comments.
markgoddard
approved these changes
Jan 19, 2022
jovial
added a commit
that referenced
this pull request
Jan 19, 2022
This brings in: - stackhpc/kolla#90 - #30
Merged
markgoddard
pushed a commit
that referenced
this pull request
Jun 5, 2024
Add initial Designate configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in a few additional features not in the regular wallaby release.