Synchronise 2023.1 with upstream #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
When neutron API is called to check requirements for the auto_allocate topology, it needs to return not only 'tenant_id' field but also 'project_id' as that is required for the policy enforcement. Without this 'project_id' field requirements check was failing for member and reader users as they got 404 from the Neutron API. And the reason why Neutron was returning 404 was that it wasn't passing policy enforcement due to missing project_id field in the 'target' object. Closes-bug: #2066369 Change-Id: Idf96a82bc6c8cb0b47dfde3baba94b42a8a8beba (cherry picked from commit dfc01be)
set_gateway_mtu runs for all the gateway ports for a network and if one of the ports get's deleted in meanwhile whole transaction fails. To handle this we need to add if_exists=True to the transaction but for that it needs to be supported in ovsdbapp. It's fixed in ovsdbapp with [1] but would require to bump ovsdbapp minimal version in requirements.txt which we normally don't do for stable branches. So using "update_lrouter_port" instead as that have the required option available. Before [2] that was only used but during the switch if_exists part was missed. [1] https://review.opendev.org/q/I56685478214aae7b6d3a2a3187297ad4eb1869a3 [2] https://review.opendev.org/c/openstack/neutron/+/762695 Closes-Bug: #2065701 Related-Bug: #2060163 Change-Id: I447990509cdea9830228d3bc92a97062cc57a472 (cherry picked from commit 5bdd0ef) Conflicts: neutron/tests/unit/fake_resources.py
ovsdbapp>=2.2.2 handles cleanup of Chassis_Private record with chassis delete so we don't need explicit delete. The compatibility part can be dropped when we update requirements.txt to ovsdbapp>=2.2.2. Closes-Bug: #2066263 Change-Id: I45c6e6a1c3536cf4f2d90b01a3577eec9eaf3743 (cherry picked from commit 20b9893) (cherry picked from commit 4221f70) (cherry picked from commit d1c5eac) Conflicts: neutron/tests/functional/base.py
github-actions
bot
added
automated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of 2023.1 from upstream stable/2023.1.