Synchronise yoga with upstream #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The table "router_extra_attributes" is a child of "router" table. Each register contains extra information that completes the router description. When using ML2/OVS mechanism driver, the methods that create and populate the "router_extra_attributes" register are always called from the L3 DVR, L3 HA and availability zones extensions. When using ML2/OVN, those extensions are not loaded and therefore the "router_extra_attributes" register is not created. Despite this register is currently not used in ML2/OVN (it will be in future features), there are some project expecting the "router_extra_attributes" register to be always created (for example, neutron-dynamic-routing [1]). This patch enforces the child register creating always when a router is created. This register is populated with the default values. This new register does not affect any current operation related to ML2/OVN nor ML2/OVS. There is a 1:1 relationship between "routers" and "router_extra_attributes". The child register is deleted by the database engine when the "routers" register is deleted (ondelete="CASCADE"). [1]https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/863713 Conflicts: neutron/objects/router.py neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py neutron/tests/unit/objects/test_router.py Closes-Bug: #1995974 Change-Id: Ic546e40513402fa101c9687acce382cd6b84356c (cherry picked from commit 2081910)
… into stable/yoga
github-actions
bot
added
automated
markgoddard
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of yoga from upstream.