Filter the ports by VNIC type #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cherry picked from https://review.opendev.org/c/openstack/neutron/+/847346 |
In ``check_baremetal_ports_dhcp_options``, the ports need to be retrieved based on the VNIC type. The VNIC type is stored in "ml2_port_bindings" table, not "ports" table. Because the ML2Plugin ``get_ports`` method can filter only by "ports" database register fields, it is needed to retrieve those ports using a custom database query and then use the plugin method to retrieve the ports, converted to dictionaries and the extensions processed. Closes-Bug: #1979643 Change-Id: Iab227d9de75e4b1b927043ce27bdc346066478e8 (cherry picked from commit b497ad1)
bbezak
force-pushed
the
backport-bug-fix-1979643
branch
from
55430c1 to
ce7a692
Compare
|
fixed indent from previous sync ======
|
bbezak
changed the title
bbezak
changed the title
bbezak
force-pushed
the
backport-bug-fix-1979643
branch
from
9603654 to
61cd541
Compare
|
fetched recent upstream version of https://review.opendev.org/c/openstack/neutron/+/868746 |
bbezak
force-pushed
the
backport-bug-fix-1979643
branch
from
61cd541 to
ce7a692
Compare
bbezak
changed the title
|
removed ttps://review.opendev.org/c/openstack/neutron/+/868746, as it will be fetched from upstream with sync |
|
ready for reviews |
|
let's merge it after this got merged - https://review.opendev.org/c/openstack/neutron/+/869112, then we can build new neutron images |
mnasiadka
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflicts resolved:
neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py:
added 'from neutron.objects import ports as ports_obj' as does upstream
neutron/objects/ports.py:
removed '@db_api.CONTEXT_READER' as it is not existing in yoga (openstack@eeb918e)
In
check_baremetal_ports_dhcp_options, the ports need to be retrieved based on the VNIC type. The VNIC type is stored in "ml2_port_bindings" table, not "ports" table. Because the ML2Pluginget_portsmethod can filter only by "ports" database register fields, it is needed to retrieve those ports using a custom database query and then use the plugin method to retrieve the ports, converted to dictionaries and the extensions processed.Closes-Bug: #1979643
Change-Id: Iab227d9de75e4b1b927043ce27bdc346066478e8 (cherry picked from commit b497ad1)