Synchronise 2025.1 with upstream #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Closes-Bug: #2084446 Change-Id: I64ad033e600c2c87af4716736c10e11c143afea2 Signed-off-by: lajoskatona <lajos.katona@est.tech> (cherry picked from commit 618c06b02f2a62819ae76871b9ad920c145f62ed)
When binding profile parameter validation was extended in change I8493cba28e92b9b36bdb952c9737c0fea6fb7b75, a subtle bug was introduced. Namely, if a binding profile specification specified ``None`` for expected capability, the code would literally look for an instance of ``None`` in the list of capabilities, as can be read from the documentation [0] this was not the intended behavior. Update unit tests that asserted the incorrect behavior. Add new unit test specifically for the case of a remote-managed vnic that also has extra capabilities. 0: https://opendev.org/openstack/neutron/src/commit/71962255dee06d75258984b39d3a5c6c6293534d/neutron/common/ovn/constants.py#L340-L353 Closes-Bug: #2116087 Change-Id: I69d49cd3737b3bee8c8b4221149085375e9ac1e2 Signed-off-by: Frode Nordahl <fnordahl@ubuntu.com> (cherry picked from commit 1e01e6a)
github-actions
bot
added
automated
priteau
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of 2025.1 from upstream stable/2025.1.