Synchronise yoga with upstream #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
DvrLocalRouter._load_used_fip_information() is called during the class init however in some cases it tries to access a network namespace which hasn't yet been created. This results in NetworkNamespaceNotFound. This change ensures that we instead create any FIP priority rules after the network namespace has been created by calling _load_used_fip_information() from the initialize function rather than in the class instantiation. Closes-Bug: #2025129 Change-Id: I41ffffeca433faab2244ff3d1876ca078ce5ebfb (cherry picked from commit c8c74f1)
Expose chassis hosting information via LSP's external_ids. This allows for projects such as ovn-bgp-agent NB driver that only connects to the NB database to consume such information (avoiding more connections to the SB database). Also stop populating the "requested-chassis" options for ports of the type virtual because it's ignored by OVN. See LP #2020058 for more information. Conflicts: neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py Closes-Bug: #2020058 Change-Id: I1fb6a9ff94376ab5f695d311b6fa8034d73cf556 Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com> (cherry picked from commit 2892695)
Based on bug #2008712 if we have a security-group which is the remote group of a 2nd security-group, the backend never deletes the rule of the 2nd group which remote_group_id is the original security-group. By AFTER_DELETE event for each rule that has the security_group_id as remote_group_id, we can make the mech drivers do their work and delete these rules in the backend. One version of this fix was merged: https://review.opendev.org/q/I207ecf7954b06507e03cb16b502ceb6e2807e0e7 and reverted due to #2019449: https://review.opendev.org/q/I077fe87435f61bd29d5c1efc979c2adebca26181 This patch is based on https://review.opendev.org/c/openstack/neutron/+/876716/1 Closes-Bug: #2008712 Related-Bug: #2019449 Change-Id: I9e8ddfa26c5402fefd573b0e2ea5f3a57983ca35 (cherry picked from commit 67a0b07)
This patch effectively reverts old patch [1]. From now on it will be not allowed to directly remove router ports which don't have fixed IPs assigned. Such ports will be treated as any other ports connected to the routers. Originally [1] was introduced to allow cleanup of the router ports for which subnets were deleted. But now it's not needed anymore as we prevent deletion of subnet if there are any ports with IP allocated from that subnet. Closes-bug: #2025056 [1] https://review.opendev.org/c/openstack/neutron/+/20424 Change-Id: I1a3723ae999fefb5dcbe3a60cf1a4902da9f0265 (cherry picked from commit 32d589f)
There is no need to clear the external_mac if DVR is enabled, not even when the port is down. This patch ensures the external_mac is only deleted when DVR is not enabled. Without this patch, if a VM with a floating IP gets deleted, and DVR is enabled, during some time the traffic gets (wrongly) centralized while it should not. And it is also generating more load on the OVN side unnecesarily. Closes-Bug: #2025264 Change-Id: I89db15dd1b629bc963f3b63926391a4a02cbedf7 (cherry picked from commit 0090572)
A TypeError was thrown during a synchronization command(neutron-ovn-db-sync-util) execution. From the code[1][2], it can be seen. The result of the AddLSwitchPortCommand command will be passed as a parameter to the UpdateLSwitchPortQosOptionsCommand. But if the logical switch port exists, the result will not be set. Therefore, when the UpdateLSwitchPortQosOptionsCommand is executed, the port_id will not be obtained, thereby throwing an exception TypeError. This patch sets the result when the logical switch port exists. [1] https://opendev.org/openstack/neutron/src/commit/b71f7ceb3e97e021cb9aeda757a7ffdeeff80e8e/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py#L488 [2] https://opendev.org/openstack/neutron/src/commit/b71f7ceb3e97e021cb9aeda757a7ffdeeff80e8e/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py#L505 Closes-Bug: #2025202 Change-Id: Ie09d9d3e5efa8a57ad11655c2eb31d2604bab326 (cherry picked from commit 65bbbce)
… into stable/yoga
github-actions
bot
added
automated
markgoddard
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of yoga from upstream.