Skip to content

Conversation

github-actions[bot]
Copy link

This PR contains a snapshot of yoga from upstream.

The "tc qdisc" command to create an ingress qdisc does not require
to define a parent qdisc [1]. The ingress qdisc "differs from other
qdiscs in that it does not occupy the root of a device".

The previous command was replacing the default root egress qdisc:
  root@dev20:~# ip netns exec ns01 tc qdisc show
  qdisc noqueue 0: dev dummy root refcnt 2

This operation is now not permitted with the new kernel.

This patch is also changing how the TC funtional tests interact with
the namespace interface created. Now the interface is set to UP before
the test starts. That changes the "tc qdisc show" command because now
the default qdisc (see the aforementioned CLI output) is now present,
as it should be in a live environment (where the interfaces are UP).

Closes-Bug: #2034540

[1]https://tldp.org/HOWTO/Adv-Routing-HOWTO/lartc.adv-qdisc.ingress.html

Conflicts:
    neutron/tests/functional/privileged/agent/linux/test_tc_lib.py

Change-Id: I2f8130dc3cf3244be2a44a4ecbdbaa9c7f865731
(cherry picked from commit 8cba9a2)
(cherry picked from commit 37d09f9)
…ion"

This reverts commit 82f06fe.

Reason for revert: the port binding handling done in this patch is
incorrect and leads to issues during the cold migration process with
trunk ports in ML2/OVN.

Change-Id: If248bcb8b1088edf5ddde20f84cd36cc27c98107
Partial-Bug: #2033887
@github-actions github-actions bot requested a review from a team as a code owner September 11, 2023 08:23
@github-actions github-actions bot added automated Automated action performed by GitHub Actions synchronisation labels Sep 11, 2023
@markgoddard markgoddard merged commit 7f8242a into stackhpc/yoga Sep 13, 2023
@markgoddard markgoddard deleted the upstream/yoga-2023-09-11 branch September 13, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated Automated action performed by GitHub Actions synchronisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants