LNX-329 - Change None to empty space inject rum script

Author: homiedopie

stackify/rum.py

@@ -13,30 +13,30 @@
 
 def insert_rum_script():
     apm_rum_script = insert_rum_script_apm()
-    if apm_rum_script:
+    if apm_rum_script is not None:
         return apm_rum_script
 
     rum_key = config.rum_key
     rum_script_url = config.rum_script_url
 
     if not rum_script_url or not rum_key:
-        return None
+        return ''
 
     transaction_id = get_transaction_id()
     if not transaction_id:
-        return None
+        return ''
 
     reporting_url = get_reporting_url()
     if not reporting_url:
-        return None
+        return ''
 
     application_name = config.application
     if not application_name:
-        return None
+        return ''
 
     environment = config.environment
     if not environment:
-        return None
+        return ''
 
     settings = {
         "ID": transaction_id
@@ -58,7 +58,7 @@ def insert_rum_script():
             settings["Trans"] = reporting_url_b64
 
     if not settings:
-        return None
+        return ''
 
     return '<script type="text/javascript">(window.StackifySettings || (window.StackifySettings = {}))</script><script src="{}" data-key="{}" async></script>'.format(
         json.dumps(settings),
@@ -77,7 +77,7 @@ def get_reporting_url():
 
 def insert_rum_script_apm():
     if not is_apm_installed():
-        return
+        return None
 
     return insert_rum_script_from_apm()
 

tests/rum/test_rum_apm.py

@@ -74,3 +74,4 @@ def test_default_insert_rum_script_from_apm_without_transaction(self):
 
         rum_data = stackify.rum.insert_rum_script()
         assert not rum_data
+        assert rum_data is ''

tests/test_rum.py

@@ -75,7 +75,8 @@ def test_default_insert_rum_script_no_transaction_id(self, func_apm):
         result = stackify.rum.insert_rum_script()
         self.reset_common_config()
 
-        assert result is None
+        assert not result
+        assert result is ''
 
     @mock.patch('stackify.rum.is_apm_installed')
     def test_default_insert_rum_script_no_key(self, func_apm):
@@ -88,6 +89,7 @@ def test_default_insert_rum_script_no_key(self, func_apm):
 
         result = stackify.rum.insert_rum_script()
         assert not result
+        assert result is ''
 
         self.reset_common_config()
 
@@ -98,6 +100,7 @@ def test_default_insert_rum_script_no_details(self, func_apm):
 
         result = stackify.rum.insert_rum_script()
         assert not result
+        assert result is ''
 
         self.reset_common_config()
 
@@ -136,6 +139,7 @@ def test_default_insert_rum_script_no_key_from_api(self, func_apm):
         self.reset_common_config()
 
         assert not result
+        assert result is ''
 
     @mock.patch('stackify.rum.is_apm_installed')
     def test_default_insert_rum_script_no_details_from_api(self, func_apm):
@@ -150,6 +154,7 @@ def test_default_insert_rum_script_no_details_from_api(self, func_apm):
         self.reset_common_config()
 
         assert not result
+        assert result is ''
 
     def update_common_config(self, rum_key=None, rum_script_url=None, application=None, environment=None):
         self.config_rum_key = stackify.config.rum_key