Skip to content

fix: stackit-cli auth get-access-token does not work as expected #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025

Conversation

Benjosh95
Copy link
Contributor

@Benjosh95 Benjosh95 commented Aug 12, 2025

Description

Github-Issue: #904

Precondition:

  • stackit auth activate-service-account ...

Bug:

  • stackit auth get-access-token returned an error message instead of a valid token.

The command only worked for the user flow.
This PR includes support for the service flow again.

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Benjosh95 Benjosh95 requested a review from a team as a code owner August 12, 2025 06:48
@Benjosh95 Benjosh95 changed the title fix: support get service account flow token again fix: stackit-cli auth get-access-token does not work as expected Aug 12, 2025
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/auth/get-access-token 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/auth 56.70% (-0.18%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/auth/get-access-token/get_access_token.go 0.00% (ø) 34 0 34
github.com/stackitcloud/stackit-cli/internal/pkg/auth/auth.go 54.17% (-1.15%) 96 (+2) 52 44 (+2) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@Benjosh95 Benjosh95 merged commit 8c76624 into main Aug 12, 2025
5 checks passed
@Benjosh95 Benjosh95 deleted the bf/cli-fix-get-access-token-service-flow branch August 12, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants