Skip to content

fix: stackit-cli auth get-access-token does not work as expected #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025
Merged

fix: stackit-cli auth get-access-token does not work as expected #922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8820251
fix: support get service account flow token again
Benjosh95 Aug 12, 2025
ae2b2d1
reduce duplicated docs
Benjosh95 Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions internal/cmd/auth/get-access-token/get_access_token.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ func NewCmd(params *params.CmdParams) *cobra.Command {
return &cliErr.SessionExpiredError{}
}

// Try to get a valid access token, refreshing if necessary
accessToken, err := auth.RefreshAccessToken(params.Printer)
accessToken, err := auth.GetValidAccessToken(params.Printer)
if err != nil {
return err
}
Expand Down
15 changes: 11 additions & 4 deletions internal/pkg/auth/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,15 +134,22 @@ func getEmailFromToken(token string) (string, error) {
return claims.Email, nil
}

// RefreshAccessToken refreshes the access token if it's expired for the user token flow.
// It returns the new access token or an error if the refresh fails.
func RefreshAccessToken(p *print.Printer) (string, error) {
// GetValidAccessToken returns a valid access token for the current authentication flow.
// For user token flows, it refreshes the token if necessary.
// For service account flows, it returns the current access token.
func GetValidAccessToken(p *print.Printer) (string, error) {
flow, err := GetAuthFlow()
if err != nil {
return "", fmt.Errorf("get authentication flow: %w", err)
}

// For service account flows, just return the current token
if flow == AUTH_FLOW_SERVICE_ACCOUNT_TOKEN || flow == AUTH_FLOW_SERVICE_ACCOUNT_KEY {
return GetAccessToken()
}

if flow != AUTH_FLOW_USER_TOKEN {
return "", fmt.Errorf("token refresh is only supported for user token flow, current flow: %s", flow)
return "", fmt.Errorf("unsupported authentication flow: %s", flow)
}

// Load tokens from storage
Expand Down
Loading